Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-33: Fixes for labels by Taxonomy #1555

Merged
merged 23 commits into from
Oct 12, 2023
Merged

fix: LEAP-33: Fixes for labels by Taxonomy #1555

merged 23 commits into from
Oct 12, 2023

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Sep 8, 2023 •
edited
Loading

  • Don't remove region after deleting the last Taxonomy label
  • Display correct labels in region info and regions list
  • Allow to use color param in Choices inside Taxonomy

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Frontend

Describe the reason for change

Taxonomy as labeling tool had major issues

What libraries were added/updated?

none

Does this change affect performance?

nope

Does this change affect security?

nope

What feature flags were used to cover this change?

fflag_feat_front_lsdv_5452_taxonomy_labeling_110823_short

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Taxonomy, Labels

@hlomzik
fix: LEAP-33: Mimic labeling Taxonomy result as Label
7525970 
- `findLabel()` for starters to use in Label context
- fix `selectedLabels` back to act the same for Labels and Taxonomy
- fix styling detection
@hlomzik
Attempt to respect showFullPath in New Taxonomy
db922ba 
It should work, but it doesn't
@github-actions github-actions bot added the fix label Sep 8, 2023
@robot-ci-heartex robot-ci-heartex mentioned this pull request Sep 8, 2023
Merged
@hlomzik
Fix node type detection
5330810 
temporary fix, should find a proper fix and source of problem later
@mihow
Copy link

mihow commented Sep 13, 2023

@hlomzik does your quazy-labels fix address the issue of Taxonomy choices not displaying in the RegionDetails component? I stubbed out a fix in #1558 but it is untested and I am pretty unfamiliar with the Label Studio codebase.

@hlomzik
Copy link
Collaborator Author

hlomzik commented Sep 25, 2023 •
edited by robot-ci-heartex
Loading

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-33/taxonomy-labels (4e64688)

Workflow run

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 4, 2023 •
edited by robot-ci-heartex
Loading

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-33/taxonomy-labels (4763635)

Workflow run

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 4, 2023

@hlomzik does your quazy-labels fix address the issue of Taxonomy choices not displaying in the RegionDetails component? I stubbed out a fix in #1558 but it is untested and I am pretty unfamiliar with the Label Studio codebase.

@mihow Hey! Sorry, that's actually a pretty different thing, allowing to label regions directly with taxonomy the same way we do with labels. But I like your approach there, we really missed Taxonomy in region's info panel! Will review it soon, thanks!

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 9, 2023

/merge master

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 9, 2023 •
edited by robot-ci-heartex
Loading

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-33/taxonomy-labels (50602ef)

Workflow run

hlomzik and others added 3 commits October 9, 2023 12:38
@hlomzik
Merge remote-tracking branch 'origin/master' into fb-leap-33/taxonomy…
50602ef 
…-labels
@hlomzik
Simplify Visibility checks
71253e8 
That also should improve performance for huge Taxonomies
@hlomzik
Currently revert old code and wrap new one with FF
65e7588 
Final decision about using stored values everywhere wil s=come soon.
For now stable bahaviour is always active with FF off.
FF on has regress for now.
@farioas
Copy link
Member

farioas commented Oct 11, 2023 •
edited by robot-ci-heartex
Loading

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-33/taxonomy-labels (7f924c4)

Workflow run

@farioas
Copy link
Member

farioas commented Oct 11, 2023 •
edited by robot-ci-heartex
Loading

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-33/taxonomy-labels (6168b40)

Workflow run

@hlomzik hlomzik marked this pull request as draft October 11, 2023 16:41
@hlomzik hlomzik marked this pull request as ready for review October 11, 2023 16:41
@hlomzik hlomzik merged commit 05b67ad into master Oct 12, 2023
@hlomzik hlomzik deleted the fb-leap-33/taxonomy-labels branch October 12, 2023 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlomzik @mihow @farioas @yyassi-heartex