-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
45 - Add a comment to a film extract #193
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Tony GONG <[email protected]>
6a9c4d7
to
58f3d99
Compare
@benel le test fonctionne localement mais pas sur github |
I don't know how it comes that it work on your computer but I found this related discussion about using multiline regex in RSpec https://stackoverflow.com/questions/5239997/regex-how-to-match-multiple-lines |
@EnzoSimonoviciUTT @jeromeBRM @ToGoSleep If you trace the test step by step by using You may find a way to wait for YouTube to be loaded:
|
@@ -40,3 +40,8 @@ | |||
Quand("je clique sur la référence temporelle {string} avec pour commentaire {string}") do |timecode, comment| | |||
find(:xpath, "//p[contains(., \"#{timecode}\")]", match: :first).click | |||
end | |||
|
|||
Quand("j’ajoute un timecode dans la glose ouverte") do | |||
find("body").send_keys([:control, :space]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for the video to be loaded.
features/step_definitions/outcome.rb
Outdated
end | ||
|
||
Alors('le texte à la fin du commentaire contient la nouvelle référence temporelle') do | ||
expect(find('.editable.content').text).to match(/[0-9:.]+ --> [0-9:.]+\n<TEXT>/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You should test the value of the
textarea
instead. - Test the regex to be sure:
- it is multiline,
- the dot match only the real dot and not any character.
@jeromeBRM @EnzoSimonoviciUTT @ToGoSleep Do not forget to tell me if you are stuck and need help between class sessions. |
2dd87c5
to
f7b3df7
Compare
Co-authored-by: Jerome BRAEMS <[email protected]> Co-authored-by: Tony GONG <[email protected]>
f7b3df7
to
9d93c98
Compare
Co-authored-by: Enzo SIMONOVICI <[email protected]>
We, BRAËMS Jerôme, VERNET William, GONG Tony and SIMONOVICI Enzo, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.