Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds steering wheel heat as its own selector #1010

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

erikn13
Copy link

@erikn13 erikn13 commented Jan 12, 2025

to allow for Low/High setting. Related PR for hyundai_kia_connect_api/feature/steering_wheel_step

nolteerik and others added 2 commits January 12, 2025 10:25
…igh setting. Related PR for hyundai_kia_connect_api/feature/steering_wheel_step
@@ -59,12 +59,23 @@ start_climate:
options:
- label: "Off"
value: "0"
- label: "Steering Wheel, Side and Back Defroster"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this impacts other regions. I'm on my phone so hard to check but could you validate?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further investigation, these particular features only exist in this form, in the KiaUvoAPIUSA

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would impact USA users?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I didn't see anything region specific in kia_uvo custom_component. The only region edited in the hyundai_kia_connect_api was the USA but the ApiImpl.py was also modified to add the option for steeringWheel. The options.heating remains the same in other territories, this just moves the steering wheel option out of that grouping to allow for granularity. I didn't see any calls related to the steering in the other regions in the hyundai_kia_connect_api. I couldn't think of a clean backwards compatability for the steeringWheel portion of the body in KiaUvoApiUSA.py.

@erikn13
Copy link
Author

erikn13 commented Jan 13, 2025

start_climate is associated with EU, CA, USA Kia, USA Hyundai, and China according to the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants