Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HTTP v1 and drop support for older versions of HTTP #7

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2023

This pull request changes the compat entry for the HTTP package from 0.9.3 to 0.9.3, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Fixes #10.

@DilumAluthge DilumAluthge force-pushed the compathelper/new_version/2023-08-29-11-46-30-681-03517010126 branch from b85736c to e03e089 Compare August 29, 2023 11:46
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84ead00) 94.20% compared to head (8993939) 94.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files           4        4           
  Lines          69       69           
=======================================
  Hits           65       65           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge DilumAluthge changed the title CompatHelper: bump compat for HTTP to 1, (keep existing compat) Update to HTTP v1 and drop support for older versions of HTTP Feb 15, 2024
@DilumAluthge
Copy link
Member

Any particular reason we need to drop support for Julia 1.5?

@DilumAluthge
Copy link
Member

Ah, I see. That's unfortunate, but not much we can do about it.

@devmotion
Copy link
Member

If we drop Julia 1.5, we have to update the branch protection settings and change the Julia 1.5 CI requirement to Julia 1.6. Alternatively, we could add a finalize Github action and make it the only requirement.

@DilumAluthge
Copy link
Member

Yeah let's take advantage of the opportunity to move to a finalize job.

@devmotion devmotion merged commit b46649f into master Feb 19, 2024
6 of 7 checks passed
@devmotion devmotion deleted the compathelper/new_version/2023-08-29-11-46-30-681-03517010126 branch February 19, 2024 06:40
@DilumAluthge
Copy link
Member

@devmotion While we're at it, can you make a PR to migrate to GitHub merge queue?

@devmotion
Copy link
Member

#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants