-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to HTTP v1 and drop support for older versions of HTTP #7
Update to HTTP v1 and drop support for older versions of HTTP #7
Conversation
b85736c
to
e03e089
Compare
…30-681-03517010126
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 4 4
Lines 69 69
=======================================
Hits 65 65
Misses 4 4 ☔ View full report in Codecov by Sentry. |
Any particular reason we need to drop support for Julia 1.5? |
HTTP 1.0.0 (and newer versions) only support Julia >= 1.6: https://github.com/JuliaHealth/SMARTBackendServices.jl/actions/runs/7945106077/job/21691345682 https://github.com/JuliaWeb/HTTP.jl/blob/6ec44e203977f4abee28fd80adfbf351a1c6629b/Project.toml |
Ah, I see. That's unfortunate, but not much we can do about it. |
If we drop Julia 1.5, we have to update the branch protection settings and change the Julia 1.5 CI requirement to Julia 1.6. Alternatively, we could add a |
Yeah let's take advantage of the opportunity to move to a |
@devmotion While we're at it, can you make a PR to migrate to GitHub merge queue? |
This pull request changes the compat entry for the
HTTP
package from0.9.3
to0.9.3, 1
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Fixes #10.