Support sort(keys(::Dict)) and sort(values(::Dict))
#56978
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
added
iteration
nsajko
reviewed
Jan 9, 2025
| @@ -1739,12 +1739,16 @@ function sort!(v::AbstractVector{T}; | |||
| end | |||
|
|
|||
| """ | |||
| sort(v::Union{AbstractVector, NTuple}; alg::Base.Sort.Algorithm=Base.Sort.defalg(v), lt=isless, by=identity, rev::Bool=false, order::Base.Order.Ordering=Base.Order.Forward) | |||
| sort(v; alg::Base.Sort.Algorithm=Base.Sort.defalg(v), lt=isless, by=identity, rev::Bool=false, order::Base.Order.Ordering=Base.Order.Forward) | |||
| sort(v::NTuple; kws...) -> NTuple | |||
There was a problem hiding this comment.
Suggested change
| sort(v::NTuple; kws...) -> NTuple | |
| sort(v::NTuple; kws...)::NTuple |
I prefer :: for declaring the return type, in fact I think the -> may be very confusing when used for this purpose, because:
->is actual Julia syntax for defining functions, with conflicting semantics (defines a function, with args on the LHS and return value on RHS)::is actual Julia syntax, too, but with semantics as expected- not sure, but I think the
->is sometimes used in doc strings to express the returned value, as opposed to the type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the sorting iterables saga:
#38328
#46104
#51977
#52010
#54494