staticdata: remove reinit_ccallable

[aviatesk]

If #56499 is merged, the functionality of jl_reinit_ccallable will become incomplete. However, it is questionable whether jl_reinit_ccallable is truly necessary. It seems to have been added in #44527, but all test cases appear to pass without it. Therefore, it might be safe to remove it altogether.

[vchuravy]

We might be missing test coverage, but I think PkgEval found this back then ...

Generally speaking a package that has a @ccallable and then a user who uses ccall to call it by name.

[gbaraldi]

I believe @topolarity touched this last, (I might be imagining it). But still we need this functionality. Otherwise what restores the ccallable pointer?

[vchuravy]

We have a test here

julia/test/precompile.jl

Line 261 in 3c7bc45

Base.@ccallable Cint f35014(x::Cint) = x+Cint(1)

&

julia/test/precompile.jl

Line 390 in 3c7bc45

@eval begin function ccallable_test()

And CI does complain: "JIT session error: Symbols not found: [ f35014 ]"

[vchuravy]

This code (or equivalent) is still needed as seen on CI.

[topolarity]

I believe @topolarity touched this last

Yeah, I was fixing a bug in this space in #55813 but I don't think it affects this PR much

[vtjnash]

Generally speaking a package that has a @ccallable and then a user who uses ccall to call it by name.

[vtjnash]

The test is for llvmcall, which is all experimental and can therefore just be deleted

[Keno]

Can you elaborate of what the difficulty of #56499 with jl_reinit_ccallable is? If we have a test for it that does raise the likelyhood that people are depending on it.

[vtjnash]

I fixed the test for CI, so that it uses the stable ccall interface instead of the unstable llvmcall one