Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix devcontainer definition #57006

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix devcontainer definition #57006

merged 1 commit into from
Jan 10, 2025
+10 −9

Conversation

M-PERSIC
Copy link
Contributor

@M-PERSIC M-PERSIC commented Jan 9, 2025 •
edited
Loading

Starting with the Julia v1.9 container, python has no installation candidate.

At the same time, modernize devcontainer.json and remove the need for a Dockerfile.

giordano
giordano approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm I can start a GitHub Codespace on the proposed branch and compile julia successfully in it with make -j2 (it took about 25 minutes)

@giordano giordano added the merge me PR is reviewed. Merge when all tests are passing label Jan 9, 2025
@IanButterworth IanButterworth merged commit b80dd58 into JuliaLang:master Jan 10, 2025
9 checks passed
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M-PERSIC @giordano @IanButterworth @oscardssmith