correct implementation of Base.copy(::Notes)

JuliaMusic · Nov 12, 2019 · bf010b7 · bf010b7
1 parent c53e4a6
commit bf010b7
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+# v1.5.2
+* Correctly implement `Base.copy(::Notes)` to copy every note, instead of copying the high-level vector (which lead to all internal notes being the same object as the non-copied version).
 # v1.5.0
 * `show` for midi now states the contained tracks
 

diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "MIDI"
 uuid = "f57c4921-e30c-5f49-b073-3f2f2ada663e"
 repo = "https://github.com/JuliaMusic/MIDI.jl.git"
-version = "1.5.1"
+version = "1.5.2"
 
 [deps]
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

diff --git a/src/note.jl b/src/note.jl
@@ -98,7 +98,7 @@ function Base.append!(n1::Notes{N}, n2::Notes{N}) where {N}
     return n1
 end
 
-Base.copy(notes::Notes) = Notes(copy(notes.notes), notes.tpq)
+Base.copy(notes::Notes) = Notes([copy(n) for n in notes], notes.tpq)
 
 
 #######################################################

diff --git a/test/note.jl b/test/note.jl
@@ -25,3 +25,11 @@ end
     n = Note(0, 1, 1, 1)
     @test pitch_to_name(n.pitch) == "C-1"
 end
+
+@testset "copying notes" begin
+    midi = readMIDIFile("doxy.mid")
+    notes = getnotes(midi.tracks[4])
+    n2 = copy(notes)
+    notes[1].pitch = 1
+    @test n2[1].pitch ≠ 1
+end