[Client Validation] Use emptyWidgetsFunctional in scoring #2083
+170
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7f699f6) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2083If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2083 |
|
Size Change: +86 B (+0.01%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
jeremywiebe
changed the title
handeyeco
approved these changes
Jan 9, 2025
| }) | ||
| // Not empty | ||
| .mockReturnValueOnce(null); | ||
| const scoringSpy = jest.spyOn(DropdownWidgetExport, "scorer"); |
There was a problem hiding this comment.
From the perspective of an outsider, I like this strategy. From the perspective of someone actively working on splitting up WidgetExports, I wonder if there's a way to do these tests without spying on WidgetExports; for example we could get 90% there by creating an empty user input object and that would keep me from having to refactor this test when I make my changes.
No action needed, just something that came to mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the work of extracting validation logic from scoring logic. This retains most of the validation that used to be intermingled with scoring.
This means that even when we strip scoring data from the widget options, we'll still be able to check if an answer is scorable.
Notably:
input-numberandnumeric-inputmissed the train here. Both of these widgets useKhanAnswerTypesright at the beginning of scoring. Further, thecoefficientanswer type allows an empty value ("") and bare negative ("-") to be treated as answers by coercing them to1and-1respectively. This means that we cannot do any validation/empty checking for these widgets because we need the fullKhanAnswerTypeslogic (which requires scoring data to work).Issue: LEMS-2561
Test plan:
yarn testyarn typecheck