Add crossOrigin attribute to <img /> element used to load images #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It turns out this isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Modern browsers track where images are loaded from and will "taint" canvases that load image data from images not loaded with proper CORS headers. Once a canvas is tainted, it cannot export its image data. Period.
This PR adds the needed image attribute so that, if the image is served with an appropriate CORS header, loading said image into a canvas won't taint it.
See Khan/live-editor#752
Test plan:
Point the
live-editorproject to this commit and try to usegetImage("avatars/mr-pants-orange")and then take a screenshot of the canvas.