-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare local and weekly benchmarks using Hatchet #1317
Open
chapman39
wants to merge
36
commits into
develop
Choose a base branch
from
feature/chapman39/hatchet
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
…o feature/chapman39/hatchet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config-build.py
tmp todo:
How the script works
The script matches two caliper files (one from weekly shared location
/usr/workspace/smithdev/califiles/serac
, one from a specified build location), and creates a Hatchet "graph frame" from the difference between these two files. If the maximum difference between any section of the graph is greater than X seconds, that benchmark will "fail." The script will do this for each benchmark.Example
../scripts/llnl/compare_benchmarks.py --current-cali-dir . --verbose --depth 2 --metric-columns "Max time/rank (inc)"
(not all graphs are shown)
You can now see the baseline and current benchmark times, as well as the difference between the two. You can also choose which "metric column" you want to see (defaults to average time per rank) and set the level of depth of the tree you wish to view. At the moment, it only displays the difference trees.
Some problems
LC system performance is inconsistent. You can run the same benchmark multiple times and get wildly different results. My understanding is this is due to the node(s) you get allocated, how busy the machine is, among other things. That being said, while this is a nice feature to look at, I'm skeptical to make this a required CI check at this time.
Improving
config-build.py
Before this PR, if you set
-DCMAKE_BUILD_TYPE=Release
when configuring Serac, the build directory will incorrectly havedebug
in the name, since theargs.buildtype
variable remainedDebug
. This PR updatesargs.buildtype
based on-DCMAKE_BUILD_TYPE
, if set - and assuming--build-type
option hasn't been set to anything else.Links