Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nudge Axis3 clip planes to avoid clipping at 0 margin #4742

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jan 19, 2025

Description

Fixes #4741

Added Refimg:

before change after change
image Screenshot 2025-01-19 182644

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

Benchmark Results

SHA: b289f81738de674d19eb8306f37fb7b1152f5369

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@kbarros
Copy link
Contributor

kbarros commented Jan 19, 2025

If this PR is merged, then it appears that Axis would need a similar nudge: #4741 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

Clipping defaults changed when upgrading to GLMakie v0.11 [noticed in Brillouin.jl]
3 participants