Add type hints to graphing #4118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for value errors in function() and inverse function()
fmuenkel
commented
Jan 20, 2025
| self.parametric_function: Callable[[float], Point3D] = lambda t: np.array( | ||
| [t, function(t), 0] | ||
| ) | ||
| self.function = function # type: ignore[assignment] |
There was a problem hiding this comment.
Don't know how to resolve this.
fmuenkel
commented
Jan 20, 2025
| f"Expected a float type result, got {type(result)}." | ||
| ) | ||
| return result | ||
| return np.log(value) / np.log(base) # type: ignore [no-any-return] |
There was a problem hiding this comment.
Not sure how to resolve this type hint error.
fmuenkel
commented
Jan 20, 2025
| @@ -141,7 +141,7 @@ def __init__(self, base: float = 10, custom_labels: bool = True) -> None: | |||
|
|
|||
| def function(self, value: float) -> float: | |||
| """Scales the value to fit it to a logarithmic scale.``self.function(5)==10**5``""" | |||
| return float(self.base**value) | |||
| return self.base**value # type: ignore [no-any-return] | |||
There was a problem hiding this comment.
Don't know yet how to resolve this.
|
Nice to see more typing work! I have also added type annotations for the graphing/scale.py in #4125, but it seems like you have also updated some warnings in the code that I haven't dealt with. Regarding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Related to #3375.
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist