fix: isValidASCIIURL should include path in check

[digiwand]

Description

When the change network confirmation is shown, If there are non-ASCII characters in the URL, we should display a warning

example input: https://infura.io/gnosis?x=iոfura.io
new URL(input).href → 'https://infura.io/gnosis?x=i%D5%B8fura.io'

Related to: https://github.com/MetaMask/MetaMask-planning/issues/2365

Related issues

Fixes: #29489
Related to: https://github.com/MetaMask/MetaMask-planning/issues/2365

Manual testing steps

1. from the console, call

 window.ethereum.request({
      "method": "wallet_addEthereumChain",
      "params": [
        {
          "chainId": "0x64",
          "chainName": "Gnosis",
          "rpcUrls": [
            "https://infura.io/gnosis?x=iոfura.io"
          ],
          "iconUrls": [
            "https://xdaichain.com/fake/example/url/xdai.svg",
            "https://xdaichain.com/fake/example/url/xdai.png"
          ],
          "nativeCurrency": {
            "name": "xDAI",
            "symbol": "xDAI",
            "decimals": 18
          },
          "blockExplorerUrls": [
            "https://blockscout.com/poa/xdai/"
          ]
        }
      ]
    });
2. observe expected error

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [376fcd1]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1657 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1424	2101	1658	155	74
		domContentLoaded	1408	2086	1632	152	73
		load	1417	2105	1657	156	75
		domInteractive	16	178	43	37	18
		backgroundConnect	9	92	26	23	11
		firstReactRender	15	77	51	24	11
		getState	4	62	14	17	8
		initialActions	0	56	3	12	6
		loadScripts	971	1566	1212	133	64
		setupStore	6	19	9	3	1
		uiStartup	1682	2427	1877	178	86

[jpuri]

Nit: isValidASCIIURL takes care of scenario when customRpcUrl is not defined.

[digiwand]

we don't want to show the error if there is no URL passed so we need to check !customRpcUrl here

[metamaskbot]

Builds ready [1f62cba]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1676 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	302	1868	1608	317	152
		domContentLoaded	1470	1813	1640	98	47
		load	1492	1872	1676	108	52
		domInteractive	24	119	38	23	11
		backgroundConnect	10	87	37	22	11
		firstReactRender	16	70	37	22	10
		getState	5	89	16	20	10
		initialActions	0	1	0	0	0
		loadScripts	1061	1375	1230	90	43
		setupStore	6	51	10	9	5
		uiStartup	1677	2453	1925	171	82

[metamaskbot]

Builds ready [36f4134]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1485 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1321	1669	1491	84	41
		domContentLoaded	1316	1649	1467	80	39
		load	1320	1660	1485	87	42
		domInteractive	24	70	42	18	9
		backgroundConnect	7	63	18	16	7
		firstReactRender	15	96	28	24	11
		getState	4	45	10	11	5
		initialActions	0	1	0	0	0
		loadScripts	949	1233	1084	73	35
		setupStore	6	60	21	22	10
		uiStartup	1536	1961	1704	119	57