Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update network switch from select RPC Modal #29521

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NidhiKJha
Copy link
Member

This Pr is to ensure that if the user try to switch a network from the select rpc modal, it's updated

Related issues

Fixes:

Manual testing steps

  1. Connect MM to a Dapp
  2. Switch to a connected network
  3. Try switching from the select rpc modal, it should work

Screenshots/Recordings

Before

Screen.Recording.2025-01-08.at.10.45.46.AM.mov

After

Screen.Recording.2025-01-08.at.6.23.16.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner January 8, 2025 18:27
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

dispatch(toggleNetworkMenu());
if (permittedAccountAddresses.length > 0) {
grantPermittedChain(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why wouldn't we check if the chainId is already permitted before calling to grant it? I mean I'm sure its idempotent but seems like we should check first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants