feat: add OneKey on device selection screen #29610

Akaryatrh · 2025-01-09T17:21:36Z

Description

Adding OneKey to the list of hardware devices on device selection page. Also, account label is now named "OneKey via Trezor".

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/762

Manual testing steps

Open account list dropdown, click on Add Account or Hardware Wallet, then click on Add Hardware Wallet
Unlock your OneKey device, select Onekey on the device list, click continue. Select your OneKey device on OS pop-up
Select one or multiple accounts from the list and validate
Check that accounts are listed as "OneKey x" on the account list.

Screenshots/Recordings

Before

Enregistrement.de.l.ecran.2025-01-13.a.15.20.49.mp4

After

Enregistrement.de.l.ecran.2025-01-13.a.15.36.08.mp4

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-09T17:21:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-09T17:55:31Z

Builds ready [e9a1c9c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1941 ± 134 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	330	2596	1866	451	217
		domContentLoaded	1424	2570	1914	283	136
		load	1478	2585	1941	280	134
		domInteractive	26	233	65	52	25
		backgroundConnect	7	61	25	17	8
		firstReactRender	17	87	47	24	12
		getState	6	66	24	20	10
		initialActions	0	0	0	0	0
		loadScripts	1010	2034	1432	239	115
		setupStore	6	64	19	19	9
		uiStartup	1784	2905	2242	322	155

metamaskbot · 2025-01-10T09:56:34Z

Builds ready [ab9e7c2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1589 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	371	1812	1536	286	137
		domContentLoaded	1430	1797	1561	102	49
		load	1439	1814	1589	108	52
		domInteractive	21	176	46	38	18
		backgroundConnect	5	73	28	22	10
		firstReactRender	15	102	50	33	16
		getState	5	40	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	1017	1327	1147	96	46
		setupStore	6	90	18	23	11
		uiStartup	1607	2409	1929	205	98

metamaskbot · 2025-01-10T09:59:01Z

Builds ready [ab9e7c2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1589 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	371	1812	1536	286	137
		domContentLoaded	1430	1797	1561	102	49
		load	1439	1814	1589	108	52
		domInteractive	21	176	46	38	18
		backgroundConnect	5	73	28	22	10
		firstReactRender	15	102	50	33	16
		getState	5	40	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	1017	1327	1147	96	46
		setupStore	6	90	18	23	11
		uiStartup	1607	2409	1929	205	98

metamaskbot · 2025-01-13T14:41:42Z

Builds ready [31e7a91]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1703 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1549	1868	1702	85	41
		domContentLoaded	1507	1857	1682	90	43
		load	1512	1861	1703	93	45
		domInteractive	25	73	40	16	8
		backgroundConnect	6	57	19	16	7
		firstReactRender	16	101	39	27	13
		getState	4	67	16	19	9
		initialActions	0	1	0	0	0
		loadScripts	1077	1384	1239	86	41
		setupStore	7	87	19	22	10
		uiStartup	1752	2578	1956	168	81

metamaskbot · 2025-01-13T16:09:31Z

Builds ready [70c0d6f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1679 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	262	1922	1623	324	156
		domContentLoaded	1536	1886	1650	83	40
		load	1540	1906	1679	95	46
		domInteractive	24	195	46	39	19
		backgroundConnect	5	95	31	25	12
		firstReactRender	16	98	45	26	12
		getState	4	53	12	11	5
		initialActions	0	1	0	0	0
		loadScripts	1139	1423	1236	68	33
		setupStore	6	82	11	16	8
		uiStartup	1743	2410	1927	153	73

metamaskbot · 2025-01-13T16:12:56Z

Builds ready [70c0d6f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1679 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	262	1922	1623	324	156
		domContentLoaded	1536	1886	1650	83	40
		load	1540	1906	1679	95	46
		domInteractive	24	195	46	39	19
		backgroundConnect	5	95	31	25	12
		firstReactRender	16	98	45	26	12
		getState	4	53	12	11	5
		initialActions	0	1	0	0	0
		loadScripts	1139	1423	1236	68	33
		setupStore	6	82	11	16	8
		uiStartup	1743	2410	1927	153	73

metamaskbot · 2025-01-13T17:31:26Z

Builds ready [fa990f1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1752 ± 115 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	313	2487	1618	464	223
		domContentLoaded	1436	2473	1731	234	112
		load	1445	2484	1752	239	115
		domInteractive	21	181	51	43	21
		backgroundConnect	4	84	18	18	9
		firstReactRender	16	94	43	29	14
		getState	4	55	23	20	10
		initialActions	0	0	0	0	0
		loadScripts	1057	2029	1296	204	98
		setupStore	6	59	12	13	6
		uiStartup	1720	2704	2072	254	122

metamaskbot · 2025-01-14T15:49:43Z

Builds ready [d96856f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1708 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1467	2161	1701	177	85
		domContentLoaded	1440	2115	1669	163	78
		load	1465	2166	1708	187	90
		domInteractive	24	86	41	20	10
		backgroundConnect	6	282	37	60	29
		firstReactRender	17	81	37	24	11
		getState	5	48	14	14	7
		initialActions	0	0	0	0	0
		loadScripts	1047	1609	1239	142	68
		setupStore	6	74	15	19	9
		uiStartup	1692	2726	1977	277	133

metamaskbot · 2025-01-14T15:53:42Z

Builds ready [d96856f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1708 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1467	2161	1701	177	85
		domContentLoaded	1440	2115	1669	163	78
		load	1465	2166	1708	187	90
		domInteractive	24	86	41	20	10
		backgroundConnect	6	282	37	60	29
		firstReactRender	17	81	37	24	11
		getState	5	48	14	14	7
		initialActions	0	0	0	0	0
		loadScripts	1047	1609	1239	142	68
		setupStore	6	74	15	19	9
		uiStartup	1692	2726	1977	277	133

metamaskbot · 2025-01-20T22:00:31Z

Builds ready [b3f66f0]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1602 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1390	1868	1604	148	71
		domContentLoaded	1377	1847	1580	149	71
		load	1382	1872	1602	152	73
		domInteractive	19	97	36	20	10
		backgroundConnect	6	58	23	14	7
		firstReactRender	15	78	31	22	11
		getState	4	62	15	16	7
		initialActions	0	1	0	0	0
		loadScripts	1006	1410	1185	129	62
		setupStore	6	48	19	17	8
		uiStartup	1580	2432	1832	218	104

metamaskbot · 2025-01-20T23:03:55Z

Builds ready [efa40a4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1768 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1488	2405	1773	206	99
		domContentLoaded	1483	2374	1749	207	99
		load	1487	2414	1768	211	101
		domInteractive	25	81	39	18	8
		backgroundConnect	5	73	21	20	9
		firstReactRender	16	74	34	22	10
		getState	4	48	11	12	6
		initialActions	0	1	0	0	0
		loadScripts	1053	1851	1298	182	87
		setupStore	6	60	10	12	6
		uiStartup	1676	2666	2056	210	101

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 112 Bytes (0.00%)
ui: 7.46 KiB (0.09%)
common: -16 Bytes (-0.00%)

Akaryatrh · 2025-01-21T08:30:20Z

ui/pages/create-account/connect-hardware/index.js

@@ -309,7 +304,7 @@ class ConnectHardwareForm extends Component {
          event: MetaMetricsEventName.AccountAdded,
          properties: {
            account_type: MetaMetricsEventAccountType.Hardware,
-            account_hardware_type: metricDeviceName,
+            account_hardware_type: deviceName,


This should not be deviceName but hardware type here. But, as discussed with MetaMask PM, to prevent issues in metrics, we'll cover this one through a different issue #29777

metamaskbot · 2025-01-21T09:07:44Z

Builds ready [f9e9fc8]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (2554 ± 505 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	263	4519	2032	1243	597
		domContentLoaded	1530	4494	2531	1049	504
		load	1542	4525	2554	1051	505
		domInteractive	25	362	95	86	41
		backgroundConnect	4	65	27	15	7
		firstReactRender	17	146	59	35	17
		getState	5	64	22	18	9
		initialActions	0	1	0	0	0
		loadScripts	1082	3615	1934	855	411
		setupStore	6	33	14	9	4
		uiStartup	1763	5129	2983	1295	622

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 112 Bytes (0.00%)
ui: 7.32 KiB (0.09%)
common: -16 Bytes (-0.00%)

metamaskbot · 2025-01-21T13:21:28Z

Builds ready [a0a95c2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1683 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	236	2005	1490	496	238
		domContentLoaded	1463	1875	1670	125	60
		load	1472	1903	1683	130	63
		domInteractive	25	99	44	20	10
		backgroundConnect	4	48	13	10	5
		firstReactRender	15	105	45	29	14
		getState	4	49	9	10	5
		initialActions	0	1	0	0	0
		loadScripts	1019	1431	1228	112	54
		setupStore	6	90	20	27	13
		uiStartup	1710	2596	1976	213	102

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 152 Bytes (0.00%)
ui: 7.82 KiB (0.10%)
common: 8 Bytes (0.00%)

metamaskbot · 2025-01-21T14:18:59Z

Builds ready [de3f4bc]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1765 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1478	2062	1768	181	87
		domContentLoaded	1468	2027	1748	175	84
		load	1477	2068	1765	181	87
		domInteractive	24	107	45	19	9
		backgroundConnect	6	43	18	12	6
		firstReactRender	15	75	37	23	11
		getState	4	54	19	18	9
		initialActions	0	1	0	0	0
		loadScripts	1056	1504	1283	142	68
		setupStore	6	53	12	13	6
		uiStartup	1630	2314	2018	195	93

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 152 Bytes (0.00%)
ui: 7.82 KiB (0.10%)
common: 8 Bytes (0.00%)

gantunesr

Haven't finished reviewing it, will continue tomorrow

gantunesr · 2025-01-22T01:44:55Z

ui/components/ui/logo/logo-onekey.tsx

+    <svg
+      width={width}
+      fill={color}
+      className={className}
+      aria-label={ariaLabel}
+      viewBox="60 0 520 288"
+      xmlns="http://www.w3.org/2000/svg"
+    >
+      <path d="M272.329 177.513C266.429 177.513 261.011 176.119 256.074 173.331C251.137 170.542 247.224 166.693 244.335 161.783C241.445 156.812 240 151.205 240 144.961C240 138.778 241.445 133.232 244.335 128.321C247.224 123.351 251.137 119.471 256.074 116.683C261.011 113.894 266.429 112.5 272.329 112.5C278.289 112.5 283.707 113.894 288.584 116.683C293.52 119.471 297.403 123.351 300.233 128.321C303.122 133.232 304.567 138.778 304.567 144.961C304.567 151.205 303.122 156.812 300.233 161.783C297.403 166.693 293.52 170.542 288.584 173.331C283.647 176.119 278.229 177.513 272.329 177.513ZM272.329 166.147C276.122 166.147 279.463 165.299 282.353 163.601C285.242 161.844 287.5 159.358 289.125 156.145C290.751 152.933 291.564 149.205 291.564 144.961C291.564 140.718 290.751 137.02 289.125 133.868C287.5 130.655 285.242 128.2 282.353 126.503C279.463 124.806 276.122 123.957 272.329 123.957C268.536 123.957 265.165 124.806 262.215 126.503C259.325 128.2 257.067 130.655 255.442 133.868C253.816 137.02 253.004 140.718 253.004 144.961C253.004 149.205 253.816 152.933 255.442 156.145C257.067 159.358 259.325 161.844 262.215 163.601C265.165 165.299 268.536 166.147 272.329 166.147Z"></path>


Can this be moved into a .svg file?

I tried to import directly the svg file as a react component, but for some reason it fails (need to declare svg module for typescript and even after it fails standardEntryPoints script).
I'd propose to try again on a separate PR and open a dedicated issue for this? (as multiple logos could use external svg files)

Akaryatrh force-pushed the feat/762-onekey branch from e9a1c9c to ab9e7c2 Compare January 10, 2025 09:22

Akaryatrh added the team-hardware-wallets label Jan 13, 2025

Akaryatrh marked this pull request as ready for review January 13, 2025 14:46

Akaryatrh force-pushed the feat/762-onekey branch from 0edd747 to fa990f1 Compare January 13, 2025 16:57

Akaryatrh force-pushed the feat/762-onekey branch from fa990f1 to d96856f Compare January 14, 2025 15:15

Akaryatrh added the needs-qa Label will automate into QA workspace label Jan 14, 2025

Akaryatrh requested review from a team as code owners January 20, 2025 21:28

Akaryatrh added 5 commits January 20, 2025 22:33

feat: add OneKey on device selection screen

d4b728c

feat: update connect hardware snapshot

fd483d5

feat: rename oneKeyViaTrezor occurences to oneKey

1b371f4

feat: switch onekey logo file to tsx

c8d579b

feat: add oneKey for metrics

f062d86

feat: add tests for getHardwareTypeForMetric

efa40a4

Akaryatrh force-pushed the feat/762-onekey branch from b3f66f0 to efa40a4 Compare January 20, 2025 22:29

feat: fix failing unit test

ffbc43a

Akaryatrh commented Jan 21, 2025

View reviewed changes

feat: adjust getHardwareTypeForMetric return type

f9e9fc8

feat: add hdpath for OneKey

a0a95c2

fix: failing test with hdpaths

de3f4bc

vivek-consensys mentioned this pull request Jan 21, 2025

[Bug] Sign typed data v1/v3 error to be updated for OneKey devices MetaMask/metamask-mobile#13098

Open

gantunesr reviewed Jan 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add OneKey on device selection screen #29610

feat: add OneKey on device selection screen #29610

Akaryatrh commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 20, 2025

metamaskbot commented Jan 20, 2025

Akaryatrh Jan 21, 2025

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

gantunesr left a comment

gantunesr Jan 22, 2025

Akaryatrh Jan 22, 2025

feat: add OneKey on device selection screen #29610

Are you sure you want to change the base?

feat: add OneKey on device selection screen #29610

Conversation

Akaryatrh commented Jan 9, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 20, 2025

metamaskbot commented Jan 20, 2025

Akaryatrh Jan 21, 2025

Choose a reason for hiding this comment

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

gantunesr left a comment

Choose a reason for hiding this comment

gantunesr Jan 22, 2025

Choose a reason for hiding this comment

Akaryatrh Jan 22, 2025

Choose a reason for hiding this comment

Akaryatrh commented Jan 9, 2025 •

edited

Loading