Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 upgrade #201

Merged
merged 8 commits into from
Oct 6, 2022
Merged

Ruby 3 upgrade #201

merged 8 commits into from
Oct 6, 2022

Conversation

grega
Copy link
Contributor

@grega grega commented Jul 13, 2022

Related

Notes

ruby-debug-ide seems to be causing issues (on docker-compose build).

Greg's output:

...
#0 242.1 Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
#0 242.1
#0 242.1     current directory: /usr/local/bundle/gems/ruby-debug-ide-0.7.3/ext
#0 242.1 /usr/local/bin/ruby mkrf_conf.rb
#0 242.1 Installing base gem
#0 242.1 Building native extensions. This could take a while...
#0 242.1 Building native extensions. This could take a while...
#0 242.1 ERROR: Failed to build gem native extension.
#0 242.1
#0 242.1     current directory: /usr/local/bundle/gems/debase-0.2.5.beta2/ext/attach
#0 242.1 /usr/local/bin/ruby -I /usr/local/lib/ruby/3.1.0 -r
#0 242.1 ./siteconf20220713-356-w6yfoj.rb extconf.rb
...

It is identical output on Tim's (M1).

TODO

  • Fix ruby-debug-ide error
    • Replicate Greg's issue
    • Gather known solutions
    • Temp edit Dockerfile to do clean bundle install (not committed)
      • Gives same error
    • Revisit what Dan and Tim did for M1, was their something about platforms there that might help?
      • Merge more recent changes from main into ruby3 branch
      • Fix 2.7.0 to 3.1.2 merge failures
      • Check for failure
        • The build now works:
          …  
          curriculum-curriculum-1   | Using debase 0.2.5.beta2  
          …   
          curriculum-curriculum-1   | Using ruby-debug-ide 0.7.3  
          …
          
  • Fix CircleCI error: Error response from daemon: manifest for circleci/ruby:3.1.2-node-browsers not found: manifest unknown
  • Fix failing RSpec tests: 289 examples, 289 failures
    • Add SMTP gems

@dumbledad dumbledad self-assigned this Oct 3, 2022
@dumbledad dumbledad marked this pull request as ready for review October 4, 2022 11:44
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to curriculum-p-ruby3-6zr9siaki04 October 4, 2022 11:49 Inactive
Copy link
Contributor

@nyashamaphosa nyashamaphosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants