Add Files class for upload/download files #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except TimeoutError as err: | ||
| raise FilesError("Timeout reached while trying to download file") from err | ||
| except ClientError as err: | ||
| raise FilesError("Failed to download file") from err |
There was a problem hiding this comment.
Maybe include the response status code in the error message? Ie catch ClientResponseError separately and then ClientError. For the ClientError case maybe include the exception in the message string?
There was a problem hiding this comment.
Not suited for MVP.
There was a problem hiding this comment.
Adding the exception to the message for ClientError is just a change on this line.
| resp.url.path if resp.url.host == self._cloud.servicehandlers_server else "" | ||
| ) | ||
| _LOGGER.log( | ||
| logging.DEBUG if isok else logging.WARNING, |
There was a problem hiding this comment.
I'd include these details in the exception message and let consumers decide how to log it. Ie always log only at debug level here.
There was a problem hiding this comment.
Not suited for MVP.
klejejs
reviewed
Jan 23, 2025
| if data is None: | ||
| raise FilesError("Failed to parse response from files handler") from None | ||
|
|
||
| resp.raise_for_status() |
There was a problem hiding this comment.
Shouldn't we raise before we try parsing the response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
Filesclass to handle the communication related to files.Eventually, all file-related functions would be moved into this new class.
But as a start, it now contains the upload and download handling.
Cleaning up the old stuff will be done in a separate PR.