Prevent any record from being mutated if external_id is nil

NetSweet · Mar 8, 2019 · 68400c0 · 68400c0
1 parent c430b7f
commit 68400c0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/netsuite/actions/add_list.rb b/lib/netsuite/actions/add_list.rb
@@ -100,8 +100,10 @@ def add_list(records, credentials = {})
             if response.success?
               response.body.map do |attr|
                 record = netsuite_records.find do |r|
-                  r.external_id == attr[:@external_id]
+                  r.external_id != nil &&
+                    r.external_id == attr[:@external_id]
                 end
+                next if record.nil?
 
                 record.instance_variable_set('@internal_id', attr[:@internal_id])
               end