Merge remote-tracking branch 'upstream/master'

README.md

@@ -75,7 +75,7 @@ NetSuite.configure do
   password 'password'
   role 10
 
-  # use `NetSuite::Utilities.netsuite_data_center_urls('TSTDRV1576318')` to retrieve the URL
+  # use `NetSuite::Utilities.data_center_url('TSTDRV1576318')` to retrieve the URL
   # you'll want to do this in a background proces and strip the protocol out of the return string
   wsdl_domain 'tstdrv1576318.suitetalk.api.netsuite.com'
 end

lib/netsuite/records/service_resale_item.rb

@@ -9,7 +9,7 @@ class ServiceResaleItem
 
       actions :get, :get_list, :add, :update, :delete, :upsert, :search
 
-      fields :available_to_partners, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :create_job, :created_date,
+      fields :available_to_partners, :cost, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :create_job, :created_date,
         :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap, :featured_description,
         :include_children, :is_donation_item, :is_fulfillable, :is_gco_compliant, :is_inactive, :is_online, :is_taxable,
         :item_id, :last_modified_date, :matrix_option_list, :matrix_type, :max_donation_amount, :meta_tag_html,

lib/netsuite/utilities.rb

@@ -78,7 +78,7 @@ def backoff(options = {})
       begin
         count += 1
         yield
-      rescue Exception => e
+      rescue StandardError => e
         exceptions_to_retry = [
           Errno::ECONNRESET,
           Errno::ETIMEDOUT,

spec/netsuite/records/service_resale_item_spec.rb

@@ -0,0 +1,134 @@
+require 'spec_helper'
+
+describe NetSuite::Records::ServiceResaleItem do
+  let(:item) { NetSuite::Records::ServiceResaleItem.new }
+
+  it 'has the right fields' do
+    [
+      :available_to_partners, :cost, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :create_job, :created_date,
+      :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap, :featured_description,
+      :include_children, :is_donation_item, :is_fulfillable, :is_gco_compliant, :is_inactive, :is_online, :is_taxable,
+      :item_id, :last_modified_date, :matrix_option_list, :matrix_type, :max_donation_amount, :meta_tag_html,
+      :minimum_quantity, :minimum_quantity_units, :no_price_message, :offer_support, :on_special, :out_of_stock_behavior,
+      :out_of_stock_message, :overall_quantity_pricing_type, :page_title, :presentation_item_list, :prices_include_tax,
+      :show_default_donation_amount, :site_category_list, :sitemap_priority, :soft_descriptor, :specials_description,
+      :store_description, :store_detailed_description, :store_display_name, :translations_list, :upc_code, :url_component,
+      :use_marginal_rates, :vsoe_deferral, :vsoe_delivered, :vsoe_permit_discount, :vsoe_price, :vsoe_sop_group
+    ].each do |field|
+      expect(item).to have_field(field)
+    end
+
+    # TODO there is a probably a more robust way to test this
+    expect(item.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
+    expect(item.pricing_matrix.class).to eq(NetSuite::Records::PricingMatrix)
+    expect(item.subsidiary_list.class).to eq(NetSuite::Records::RecordRefList)
+  end
+
+  it 'has the right record_refs' do
+    [
+      :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account,
+      :issue_product, :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code,
+      :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :store_display_image,
+      :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type
+    ].each do |record_ref|
+      expect(item).to have_record_ref(record_ref)
+    end
+  end
+
+  describe '.get' do
+    context 'when the response is successful' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => { :item_id => 'penguins' }) }
+
+      it 'returns a ServiceResaleItem instance populated with the data from the response object' do
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::ServiceResaleItem, :external_id => 20], {}).and_return(response)
+        customer = NetSuite::Records::ServiceResaleItem.get(:external_id => 20)
+        expect(customer).to be_kind_of(NetSuite::Records::ServiceResaleItem)
+        expect(customer.item_id).to eql('penguins')
+      end
+    end
+
+    context 'when the response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+
+      it 'raises a RecordNotFound exception' do
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::ServiceResaleItem, :external_id => 20], {}).and_return(response)
+        expect {
+          NetSuite::Records::ServiceResaleItem.get(:external_id => 20)
+        }.to raise_error(NetSuite::RecordNotFound,
+          /NetSuite::Records::ServiceResaleItem with OPTIONS=(.*) could not be found/)
+      end
+    end
+  end
+
+  describe '#add' do
+    let(:item) { NetSuite::Records::ServiceResaleItem.new(:cost => 100, :is_inactive => false) }
+
+    context 'when the response is successful' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
+
+      it 'returns true' do
+        expect(NetSuite::Actions::Add).to receive(:call).
+            with([item], {}).
+            and_return(response)
+        expect(item.add).to be_truthy
+      end
+    end
+
+    context 'when the response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+
+      it 'returns false' do
+        expect(NetSuite::Actions::Add).to receive(:call).
+            with([item], {}).
+            and_return(response)
+        expect(item.add).to be_falsey
+      end
+    end
+  end
+
+  describe '#delete' do
+    context 'when the response is successful' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
+
+      it 'returns true' do
+        expect(NetSuite::Actions::Delete).to receive(:call).
+            with([item], {}).
+            and_return(response)
+        expect(item.delete).to be_truthy
+      end
+    end
+
+    context 'when the response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+
+      it 'returns false' do
+        expect(NetSuite::Actions::Delete).to receive(:call).
+            with([item], {}).
+            and_return(response)
+        expect(item.delete).to be_falsey
+      end
+    end
+  end
+
+  describe '#to_record' do
+    before do
+      item.item_id = 'penguins'
+      item.is_online     = true
+    end
+
+    it 'can represent itself as a SOAP record' do
+      record = {
+        'listAcct:itemId' => 'penguins',
+        'listAcct:isOnline'     => true
+      }
+      expect(item.to_record).to eql(record)
+    end
+  end
+
+  describe '#record_type' do
+    it 'returns a string of the SOAP type' do
+      expect(item.record_type).to eql('listAcct:ServiceResaleItem')
+    end
+  end
+
+end