Remove applications that depend on python2Packages (Part 2) #154697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
mweinelt
force-pushed
the
python2-byebye
branch
2 times, most recently
from
d5391c6 to
9eb92b7
Compare
|
@thoughtpolice |
mweinelt
force-pushed
the
python2-byebye
branch
2 times, most recently
from
a0e2336 to
702e275
Compare
|
|
You can remove curaByDagoma. I'm not using it anymore and I bet nobody else ever did. |
|
thanks for the cleanup! |
romildo
approved these changes
Jan 12, 2022
|
Not aware of any benefit of getmail over getmail6 now that I look at this pair in Nixpkgs… |
|
Tailor and csv2svn (that is also cvs2git) seem useful and trivial to fix via PyPy2. #154752 |
mweinelt
force-pushed
the
python2-byebye
branch
from
c564f47 to
6bbeaa3
Compare
Should we turn getmail into an alias for getmail6 or suggest using getmail6 in the appropriate throw? |
|
Upstream promises to be drop-in replacement, so I guess alias could be fine. (I have not tried using getmail6 as I ended up consolidating on fdm instead for unrelated reasons) |
I did the latter. |
mweinelt
force-pushed
the
python2-byebye
branch
from
ba7d397 to
431d61f
Compare
Ships python2 scripts and last updated in 2018.
Stuck on python2 and last release in 2010. > NameError: name 'execfile' is not defined
The package was not updated since 2019 and requires python2 only dependencies.
Only consumer was blink sip client, which was removed.
The packaged version required python2, updating it showed it doesn't work, since it tries to write to its read-only output directory. Also renpy now requires their own pygame_sdl2 fork to build. More work on this would be required, and since there is no maintainer at this time I opted for the removal.
The package is unmaintained and uses python2. There are newer upstream versions, but upgrading the package requires some dedication, which only a maintainer should need to provide.
Requires pygtk2, which is python2 only and upstream last touched that script in 2011.
Relies on python2 and last upstream release in 2015. > AttributeError: 'str' object has no attribute 'decode'
Still actively developed and yet stuck on python2. Also marked as vulnerable and their issue tracker contains yet another security issue reported in 2021/10 that the upstream hasn't acknowledged yet. Mind blown. Closes: NixOS#135543, NixOS#97274, NixOS#97275
Removed because it requires python2 and the upstream repository looks undermaintained.
Claims to support python3, but I'm seeing it use implicit relative imports and it also has not adapted to python3.8 gettext API changes. Removed for working only with python2.
And use python3.
Also brings it closer to building again. Currently fails with: ``` CMake Error at platforms/scripts/cmake_install.cmake:54 (file): file INSTALL cannot find "/build/source/build/bin/afu_platform_config": No such file or directory. Call Stack (most recent call first): platforms/cmake_install.cmake:55 (include) cmake_install.cmake:58 (include) make: *** [Makefile:120: install] Error 1 ```
Stuck on python2 and there is a fork that isn't. Recommend getmail6
instead.
```
Traceback (most recent call last):
File "/build/getmail-5.14/nix_run_setup", line 8, in <module>
exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
File "setup.py", line 51
print 'Default installation directories:'
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print('Default installation directories:')?
```
Doesn't support recent python3 versions that use `async` as a keyword.
```
File "/build/source/mididings/units/call.py", line 36
def __init__(self, function, async, cont):
^
SyntaxError: invalid syntax
```
Last release from 2019, hasn't migrated to python3.
```
Traceback (most recent call last):
File "/build/DisplayCAL-3.8.9.3/nix_run_setup", line 8, in <module>
exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
File "setup.py", line 258
print "Bumping version number %s ->" % \
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Bumping version number %s ->" % \)?
```
Fixes osmnx build, that previously introduced two gdal versions.
mweinelt
force-pushed
the
python2-byebye
branch
from
431d61f to
554616d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#148779
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes