Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exa: 0.10.1 -> unstable-2023-03-01 #240490

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented Jun 29, 2023

Description of changes

same reason as last time:

exa hasn't seen a release for 2 years

Things done
  • Built on platform(s)
    • [] x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@moni-dz
Copy link
Contributor Author

moni-dz commented Jun 29, 2023

Result of nixpkgs-review pr 240490 run on aarch64-darwin 1

2 packages built:
  • exa
  • exa.man

@moni-dz
Copy link
Contributor Author

moni-dz commented Jun 29, 2023

Result of nixpkgs-review pr 240490 run on x86_64-darwin 1

2 packages built:
  • exa
  • exa.man

pkgs/tools/misc/exa/default.nix Outdated Show resolved Hide resolved
@moni-dz moni-dz requested a review from SuperSandro2000 July 1, 2023 05:39
@SuperSandro2000 SuperSandro2000 merged commit 4444693 into NixOS:master Jul 5, 2023
@sersorrel
Copy link
Contributor

There's at least one regression in unreleased exa versions: ogham/exa#1198

What was new that merited the update in nixpkgs, ooi?

@SuperSandro2000
Copy link
Member

exa didn't have a release for a longer time and cherry-picking multiple patches is cumbersome.
Maybe we should mark it broken/replace it with lsd?

@sersorrel
Copy link
Contributor

lsd looks interesting, but given exa still basically works I think removing it would be disruptive for no real reason. (if it were a real drop-in replacement I could see the argument, but it looks like the default lsd colour scheme is unreadable in my terminal.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants