Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastfetch: 2.33.0 → 2.34.0 #372438

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fastfetch: 2.33.0 → 2.34.0 #372438

merged 1 commit into from
Jan 10, 2025

Conversation

Rishik-Y
Copy link
Contributor

@Rishik-Y Rishik-Y commented Jan 9, 2025

Package Information

  • Package name: fastfetch
  • Latest released version: 2.34.0
  • Current version on the unstable channel: 2.33.0
  • Current version on the stable/release channel: 2.33.0

Maintainer Ping

@luftmensch-luftmensch @khaneliman

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@MithicSpirit MithicSpirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review isn't working for me, but building it directly seems to work. lgtm.

@Defelo
Copy link
Member

Defelo commented Jan 9, 2025

@Rishik-Y Please squash your two commits into one

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372438


x86_64-linux

✅ 2 packages built:
  • fastfetch
  • fastfetch.man

aarch64-linux

✅ 2 packages built:
  • fastfetch
  • fastfetch.man

x86_64-darwin

✅ 2 packages built:
  • fastfetch
  • fastfetch.man

aarch64-darwin

✅ 2 packages built:
  • fastfetch
  • fastfetch.man

@Rishik-Y
Copy link
Contributor Author

@Rishik-Y Please squash your two commits into one

Thank you for the reminder (Forgot about that)
i have squashed the 2 commits just now

@khaneliman khaneliman merged commit 91871fb into NixOS:master Jan 10, 2025
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants