Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] account_tax_round_down #2005

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

yostashiro
Copy link
Member

This module provides the function of rounding down the tax amount in invoices (and also
other business documents such as sales orders and purchase orders).

By default, Odoo uses the "HALF-UP" method to round tax amounts. However, in some
regions, such as Japan, some industries have a common practice of rounding down instead.
This module accommodates such local conventions by offering an alternate rounding method.

@qrtl QT4986

@yostashiro yostashiro force-pushed the 16.0-add-account_tax_round_down branch 4 times, most recently from eff818b to 6510acb Compare December 31, 2024 17:34
@yostashiro
Copy link
Member Author

There seems to be a happy-new-year error in a test from account_fiscal_year_auto_create, which I think will be cleared if I push again tomorrow.

2024-12-31 17:38:47,994 929 ERROR odoo odoo.addons.account_fiscal_year_auto_create.tests.test_module: FAIL: TestModule.test_cron
Traceback (most recent call last):
  File "/__w/account-financial-tools/account-financial-tools/account_fiscal_year_auto_create/tests/test_module.py", line 52, in test_cron
    self.assertFalse(new_fiscal_year)
AssertionError: account.fiscal.year(5,) is not false

This line seems to be an issue: https://github.com/OCA/account-financial-tools/blob/2ae3d17/account_fiscal_year_auto_create/models/account_fiscal_year.py#L24

CC: @legalsylvain

@yostashiro yostashiro force-pushed the 16.0-add-account_tax_round_down branch from 6510acb to bc6afb1 Compare January 1, 2025 14:25
@yostashiro
Copy link
Member Author

I was wondering if there is any real need in the community outside Japan for rounding down calculated tax amounts. If not, I might just include this module in the l10n-japan repo instead. Your comments are welcome.

Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code check and functional review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants