Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/stops-icon-type-display #105

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

Ahmedhossamdev
Copy link
Member

@Ahmedhossamdev Ahmedhossamdev commented Nov 4, 2024

Fixes: #103

1. Enhanced Stop Data Structure

  • Merged routes referenced directly with their corresponding route IDs in the stop during API fetching
  • Each stop object now includes its associated route data, making it easier to access route details for future features

2. Simplified Stop Display Logic

  • Removed reactivity for the showAllStops property
  • All stops now display on the map by default when no route is selected, simplifying the display logic

3. Optimized Stops Location Fetch

  • Prevented unnecessary stops-for-location fetch calls from running in the background when drawing a route on the map
  • This optimization reduces redundant API calls and enhances performance

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great, but I'm noticing one behavioral issue that is confusing me. Stop ID 40_99610 should be displayed as light rail, but it's showing up as a bus on the map.

image

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for tracking down those final issues! <3

@aaronbrethorst aaronbrethorst merged commit c8bbba9 into main Nov 6, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the refactor/stops-icon-type-display branch November 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route Type Icon Regression
2 participants