Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/make-optional-env-vars-dynamic #124

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Refactor/make-optional-env-vars-dynamic #124

merged 6 commits into from
Nov 15, 2024

Conversation

Ahmedhossamdev
Copy link
Member

fixes: #117

aaronbrethorst
aaronbrethorst requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's a small change to make in the README, but otherwise this is ready to go. Thanks for jumping on this!

README.md Outdated Show resolved Hide resolved
aaronbrethorst
aaronbrethorst approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbrethorst aaronbrethorst merged commit 10bad4f into main Nov 15, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the refactor/make-optional-env-vars-dynamic branch November 15, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all optional environment variables dynamic
2 participants
@Ahmedhossamdev @aaronbrethorst