Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dark mode styling for /stop/[stopid] #161

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

Kentokamoto
Copy link
Contributor

This addresses the following issues: #145, #146, #147
Dark mode was not being rendered correctly when enabled. This adds TailwindCSS styling.

The shades of gray and white are not very formulaic but I went with what "looked right". Might be worth discussing some pre-defined colors for both light and dark so we don't continue to choose from every color option available.

Screenshot 2025-01-07 at 20 25 18 Screenshot 2025-01-07 at 20 42 00

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

@Ahmedhossamdev
Copy link
Member

Hey @Kentokamoto,

Thanks for tackling the dark mode issues! I agree the colors feel a bit random, but we can clean that up later once we figure out the right palette. Awesome work for now, though! 🙌

@Ahmedhossamdev Ahmedhossamdev merged commit c6d92f2 into OneBusAway:main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants