Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary Color Customization #168

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tarunsinghofficial
Copy link
Collaborator

@tarunsinghofficial tarunsinghofficial commented Jan 17, 2025

PR Fixes #155

Changes Done:

  • Implemented primary color customization throughout the app in major components including buttons, texts, backgrounds, etc using the APP_PRIMARY_COLOR environment variable.
  • Changed the background UI of RouteModal and StopPane.

Screenshots:

image
image
image

@coveralls
Copy link

coveralls commented Jan 17, 2025

Coverage Status

coverage: 5.54% (-0.01%) from 5.55%
when pulling fb2366c on tarunsinghofficial:feature/primary-color-custom
into 35a7025 on OneBusAway:main.

@tarunsinghofficial tarunsinghofficial changed the title WIP- Primary Color Customization Primary Color Customization Jan 17, 2025
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting APP_PRIMARY_COLOR as an environment variable is confusing to me: we don't set any other configuration values via environment variable.

I could see this making sense if it was possible to set APP_PRIMARY_COLOR within the .env file but that doesn't seem to work. Please let me know if I'm missing something here, and also please add documentation to the README.

@tarunsinghofficial
Copy link
Collaborator Author

Setting APP_PRIMARY_COLOR as an environment variable is confusing to me: we don't set any other configuration values via environment variable.

I could see this making sense if it was possible to set APP_PRIMARY_COLOR within the .env file but that doesn't seem to work. Please let me know if I'm missing something here, and also please add documentation to the README.

@aaronbrethorst You're right that setting the primary color via environment variable might seem inconsistent with our other configuration patterns. However, I've found that it does work when properly configured.

It wasn't working earlier because, without the quotes, the color value was being interpreted as a comment, and without dotenv, the environment variables weren't being properly loaded into the Tailwind configuration.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but there are a few more changes that need to be done before this can be merged:

  • Secondary brand color needs the same treatment as primary color
  • Add examples of both to .env.example

@tarunsinghofficial
Copy link
Collaborator Author

Looking good, but there are a few more changes that need to be done before this can be merged:

  • Secondary brand color needs the same treatment as primary color
  • Add examples of both to .env.example

Done the changes. Ready to 🚀 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Primary Color Customization via Environment Variables
3 participants