Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the CI Workflow #19

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Improved the CI Workflow #19

merged 4 commits into from
Jul 8, 2024

Conversation

tarunsinghofficial
Copy link
Collaborator

@tarunsinghofficial tarunsinghofficial commented Jul 7, 2024

Fixes #13

Tasks Done

  • Cache npm install artifacts
  • More verbose error reporting from the prettier and eslint commands.

Files Changed:
All modifications done within the .github/workflows/lint.yml file

@aaronbrethorst
Copy link
Member

Looks like you have a CI failure with prettier:

image

@tarunsinghofficial
Copy link
Collaborator Author

Looks like you have a CI failure with prettier:

image

Looks like you have a CI failure with prettier:

image

Looks like you have a CI failure with prettier:

image

Yes, I'm still testing this. I'm new to CI/CD therefore, it is taking some time to me to learn.

@tarunsinghofficial
Copy link
Collaborator Author

Hi @aaronbrethorst,

The PR is now working correctly. Here is the ss of the logs:
image

Let me know if this is correct.
Thanks

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@aaronbrethorst aaronbrethorst merged commit 6de66a5 into main Jul 8, 2024
2 checks passed
@aaronbrethorst aaronbrethorst deleted the improve-ci branch July 8, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI
2 participants