Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Region Name text to OBA Logo #23

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Changed the Region Name text to OBA Logo #23

merged 1 commit into from
Jul 12, 2024

Conversation

tarunsinghofficial
Copy link
Collaborator

Fixes #20

Tasks done:

  • Added the logo in the navbar (with some roundness for better UI)
  • The logo URL is added in the .env file (currently using the imgur for uploading the logo to get the URL).
    The logo is wrapped in a hyperlink that navigates back to the root path and use the value of PUBLIC_OBA_REGION_NAME for its alt attribute.

image

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@aaronbrethorst aaronbrethorst merged commit a7e312b into main Jul 12, 2024
2 checks passed
@aaronbrethorst aaronbrethorst deleted the logo-feat branch July 12, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a customizable logo in the navigation bar
2 participants