Implemented the Bus Route, Draw polyline feat, and hidden unrelated stops #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The feature is working correctly but there's one issue left. When we try to choose a new stop, the old bus route is not removed. So, working on the leftover issue now. |
aaronbrethorst
requested changes
Aug 13, 2024
src/components/map/GoogleMap.svelte
Outdated
| @@ -51,20 +56,54 @@ | |||
| async function loadStopsAndAddMarkers(lat, lng) { | |||
| const json = await loadStopsForLocation(lat, lng); | |||
| const stops = json.data.list; | |||
| allStops = [...allStops, ...stops]; | |||
There was a problem hiding this comment.
be sure to de-dupe these lists as you merge them.
There was a problem hiding this comment.
sure, done.
src/components/map/GoogleMap.svelte
Outdated
| function clearAllMarkers() { | ||
| markers.forEach(({ marker, overlay, element }) => { | ||
| if (marker) { | ||
| marker.setMap(null); |
There was a problem hiding this comment.
this can be simplified to marker?.setMap(null)
There was a problem hiding this comment.
sure, done the optional chaining.
| if (marker) { | ||
| marker.setMap(null); | ||
| } | ||
| if (overlay) { |
src/components/map/GoogleMap.svelte
Outdated
| overlay.onRemove(); | ||
| } | ||
| } | ||
| if (element && element.parentNode) { |
src/components/map/GoogleMap.svelte
Outdated
| allStops.forEach((s) => addMarker(s)); | ||
| } | ||
|
|
||
| /* function markerExists(s) { |
There was a problem hiding this comment.
deleted the component
src/components/map/GoogleMap.svelte
Outdated
| @@ -107,6 +146,11 @@ | |||
| container.style.position = 'absolute'; | |||
| this.getPanes().overlayMouseTarget.appendChild(container); | |||
| }; | |||
| overlay.onRemove = function () { | |||
| if (container.parentNode) { | |||
There was a problem hiding this comment.
use optional chaining here too to get rid of the if statement
There was a problem hiding this comment.
removed the if statement in place of optional chaining.
aaronbrethorst
force-pushed
the
bus-route
branch
from
7018abc to
6b2161f
Compare
Fixes #24 - Trip Details List and Map Overlay Fixes #29 - The bus's route should also be projected onto the map Fixes #30 - Hide unrelated stops on the map while a route line is being displayed Also, checks to see if `window.google` exists, and only loads the Google Maps library if it does not. This resolves a warning in the console. Co-authored-by: tarunsinghofficial <[email protected]>
aaronbrethorst
force-pushed
the
bus-route
branch
from
6b2161f to
d32218b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30 #29 #24 issues.