Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the feature for hiding the bus route on back to button #33

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Added the feature for hiding the bus route on back to button #33

merged 3 commits into from
Aug 21, 2024

Conversation

tarunsinghofficial
Copy link
Collaborator

Fixes #32

aaronbrethorst
aaronbrethorst requested changes Aug 18, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! When I click the "Back" button from the trip details back to the stop pane content, I am seeing the route polyline disappear as expected, but the stops aren't reappearing until I close the modal.

aaronbrethorst
aaronbrethorst approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 👍

@aaronbrethorst aaronbrethorst merged commit c5fec32 into main Aug 21, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the busroute-feat branch August 21, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide the bus route when the ArrivalDeparture component disappears, instead of the StopPane
2 participants
@tarunsinghofficial @aaronbrethorst