Enhancement/polyline-arrow-symbol #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To 
|
aaronbrethorst
requested changes
Aug 23, 2024
| @@ -0,0 +1,4 @@ | |||
| export const COLORS = { | |||
There was a problem hiding this comment.
Nice work. Great you created the colors file separately. For better visibility, we can use the polyline arrow color as #8250DF.
There was a problem hiding this comment.
awesome! I will try it
| * @param {google.maps.Polyline} polyline - The polyline to which the arrow will be added. | ||
| */ | ||
| export function addArrowToPolyline(polyline) { | ||
| const arrowSymbol = { |
There was a problem hiding this comment.
Adding a check at the beginning of the function to validate the polyline parameter will be great, right @Ahmedhossamdev @aaronbrethorst? Something like this:
if (!(polyline instanceof google.maps.Polyline)) {
console.error('Invalid polyline');
return;
}
There was a problem hiding this comment.
Yep, that’s a great idea for checking the polyline parameter. Moving to TypeScript could also improve type safety and help as the project grows.
tarunsinghofficial
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Nicely done @Ahmedhossamdev. I have added my suggestions on some code lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the addArrowToPolyline function, which adds a red arrow to a polyline on Google Maps like android app. This can help users easily see the direction of the bus, improving the overall ux. The arrow repeats every 50 pixels along the polyline, and it can be adjusted.