Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bounding-box-cache #54

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Feat/bounding-box-cache #54

merged 8 commits into from
Oct 21, 2024

Conversation

Ahmedhossamdev
Copy link
Member

#51

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you've structured this. I think it looks good, but I see a lot of cache misses, even when I drag into the same area over and over.

image

Can you think of ways we could increase the cache hit rate?

@Ahmedhossamdev
Copy link
Member Author

Ahmedhossamdev commented Oct 19, 2024

@aaronbrethorst

I think we can set the digits after the point to be fixed to 1 or 2 digits only, and we can increase the radius as well; this will improve the cache hit for sure, and if users want to load more data, they can invalidate the cache by zooming in.

@aaronbrethorst aaronbrethorst merged commit 29495a9 into main Oct 21, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the feat/bounding-box-cache branch October 21, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants