3.0.4 - Release - Add back features, bug fixes #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2025 16:39
Motivation: we're unregistering the legacy SW (.php extension) anyway. Logic led to defaulting to false & using root scope
Motivation: important feature / should not have been removed
sherwinski
approved these changes
Jan 3, 2025
| $onesignal_settings['app_rest_api_key'] = sanitize_text_field($_POST['onesignal_rest_api_key']); | ||
| } | ||
| // Save the auto send notifications setting | ||
| $auto_send = isset($_POST['onesignal_auto_send']) ? 1 : 0; |
There was a problem hiding this comment.
Question: Is it enough to check that onesignal_auto_send exists here, or should we ensure that its value is set to 1?
There was a problem hiding this comment.
Good question. It won't come through at all from the POST action if unchecked.
Comment on lines
65
to
70
| foreach ($json->segments as $segment) { | ||
| $selected = isset($post->os_meta['os_segment']) && $post->os_meta['os_segment'] === $segment->name ? 'selected' : ''; | ||
| echo '<option value="' . esc_attr($segment->name) . '"' . $selected . '>' . esc_html($segment->name) . '</option>'; | ||
| } |
There was a problem hiding this comment.
Question: this might be overly cautious but do we need to add a check for if $segment->name is set?
added 5 commits
January 2, 2025 18:43
Motivation: was previously breaking the page if say, the App ID was incorrect
Motivation: logic was incorrect + required an API key even if not changing it
Motivation: highly requested feature was removed in v3
Motivation: ship 3.0.4 - Added features: auto-send on publish, UTM tags - Bug fixes: validation issues on settings form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line summary
Release 3.0.4 with new features, bug fixes, and clean-up.
Description
This update introduces several improvements and fixes in preparation for the 3.0.4 release:
New Features
Bug Fixes
onesignal-metabox.php: Fixed issues where incorrect App IDs or similar API errors would break the page.Clean-up
readme.txtfileRelease Notes
This change is