fix(protocol-designer): fix modal position (#16733)

* fix(protocol-designer): fix modal position
Opentrons · Nov 8, 2024 · 041c11a · 041c11a
1 parent 8fe6a43
commit 041c11a
Show file tree

Hide file tree

Showing 18 changed files with 20 additions and 2 deletions.
diff --git a/protocol-designer/src/components/modals/AutoAddPauseUntilTempStepModal.tsx b/protocol-designer/src/components/modals/AutoAddPauseUntilTempStepModal.tsx
@@ -30,6 +30,7 @@ export const AutoAddPauseUntilTempStepModal = (props: Props): JSX.Element => {
 
   return (
     <Modal
+      marginLeft="0"
       title={t('auto_add_pause_until_temp_step.redesign.title', {
         module: displayModule,
         temp: displayTemperature,

diff --git a/protocol-designer/src/components/modals/ConfirmDeleteModal.tsx b/protocol-designer/src/components/modals/ConfirmDeleteModal.tsx
@@ -50,6 +50,7 @@ export function ConfirmDeleteModal(props: Props): JSX.Element {
 
   return createPortal(
     <Modal
+      marginLeft="0"
       title={t(`confirm_delete_modal.${modalType}.title`)}
       titleElement1={
         <Icon name="alert-circle" color={COLORS.yellow50} size="1.25rem" />

diff --git a/protocol-designer/src/organisms/AnnouncementModal/index.tsx b/protocol-designer/src/organisms/AnnouncementModal/index.tsx
@@ -49,6 +49,7 @@ export const AnnouncementModal = (
     <>
       {showAnnouncementModal && (
         <Modal
+          marginLeft="0"
           title={heading}
           type="info"
           footer={

diff --git a/protocol-designer/src/organisms/BlockingHintModal/index.tsx b/protocol-designer/src/organisms/BlockingHintModal/index.tsx
@@ -48,6 +48,7 @@ export function BlockingHintModal(props: HintProps): JSX.Element {
 
   return createPortal(
     <Modal
+      marginLeft="0"
       type="warning"
       zIndexOverlay={15}
       title={t(`hint.${hintKey}.title`)}

diff --git a/protocol-designer/src/organisms/ConfirmDeleteStagingAreaModal/index.tsx b/protocol-designer/src/organisms/ConfirmDeleteStagingAreaModal/index.tsx
@@ -25,6 +25,7 @@ export function ConfirmDeleteStagingAreaModal(
   return createPortal(
     <HandleEnter onEnter={onConfirm}>
       <Modal
+        marginLeft="0"
         zIndexOverlay={11}
         title={t('staging_area_has_labware')}
         type="info"

diff --git a/protocol-designer/src/organisms/DefineLiquidsModal/index.tsx b/protocol-designer/src/organisms/DefineLiquidsModal/index.tsx
@@ -169,6 +169,7 @@ export function DefineLiquidsModal(
       }}
     >
       <Modal
+        marginLeft="0"
         zIndexOverlay={15}
         width="42.0625rem"
         title={

diff --git a/protocol-designer/src/organisms/EditInstrumentsModal/index.tsx b/protocol-designer/src/organisms/EditInstrumentsModal/index.tsx
@@ -174,6 +174,7 @@ export function EditInstrumentsModal(
   return createPortal(
     <HandleEnter onEnter={handleOnSave}>
       <Modal
+        marginLeft="0"
         title={
           page === 'add'
             ? t('shared:edit_pipette')

diff --git a/protocol-designer/src/organisms/EditNickNameModal/index.tsx b/protocol-designer/src/organisms/EditNickNameModal/index.tsx
@@ -40,6 +40,7 @@ export function EditNickNameModal(props: EditNickNameModalProps): JSX.Element {
   return createPortal(
     <HandleEnter onEnter={saveNickname}>
       <Modal
+        marginLeft="0"
         title={t('rename_labware')}
         type="info"
         onClose={onClose}

diff --git a/protocol-designer/src/organisms/EditProtocolMetadataModal/index.tsx b/protocol-designer/src/organisms/EditProtocolMetadataModal/index.tsx
@@ -50,6 +50,7 @@ export function EditProtocolMetadataModal(
 
   return createPortal(
     <Modal
+      marginLeft="0"
       title={t('shared:edit_protocol_metadata')}
       type="info"
       closeOnOutsideClick

diff --git a/protocol-designer/src/organisms/FileUploadMessagesModal/index.tsx b/protocol-designer/src/organisms/FileUploadMessagesModal/index.tsx
@@ -31,6 +31,7 @@ export function FileUploadMessagesModal(): JSX.Element | null {
 
   return (
     <Modal
+      marginLeft="0"
       type={message?.isError ? 'error' : 'info'}
       title={title}
       closeOnOutsideClick

diff --git a/protocol-designer/src/organisms/IncompatibleTipsModal/index.tsx b/protocol-designer/src/organisms/IncompatibleTipsModal/index.tsx
@@ -37,6 +37,7 @@ export function IncompatibleTipsModal(
   return (
     <HandleEnter onEnter={handleShowAllTips}>
       <Modal
+        marginLeft="0"
         title={t('incompatible_tips')}
         type="warning"
         closeOnOutsideClick

diff --git a/protocol-designer/src/organisms/LabwareUploadModal/index.tsx b/protocol-designer/src/organisms/LabwareUploadModal/index.tsx
@@ -43,6 +43,7 @@ export function LabwareUploadModal(): JSX.Element | null {
 
   return (
     <Modal
+      marginLeft="0"
       type={
         message.messageType === 'ASK_FOR_LABWARE_OVERWRITE'
           ? 'warning'

diff --git a/protocol-designer/src/organisms/RenameStepModal/index.tsx b/protocol-designer/src/organisms/RenameStepModal/index.tsx
@@ -53,6 +53,7 @@ export function RenameStepModal(props: RenameStepModalProps): JSX.Element {
 
   return createPortal(
     <Modal
+      marginLeft="0"
       title={t('shared:name_step')}
       type="info"
       closeOnOutsideClick

diff --git a/protocol-designer/src/organisms/SelectWellsModal/index.tsx b/protocol-designer/src/organisms/SelectWellsModal/index.tsx
@@ -101,6 +101,7 @@ export const SelectWellsModal = (
 
   return (
     <Modal
+      marginLeft="0"
       width="42.0625rem"
       zIndex={15}
       zIndexOverlay={11}

diff --git a/protocol-designer/src/organisms/TipPositionModal/ZTipPositionModal.tsx b/protocol-designer/src/organisms/TipPositionModal/ZTipPositionModal.tsx
@@ -140,8 +140,9 @@ export function ZTipPositionModal(props: ZTipPositionModalProps): JSX.Element {
 
   return createPortal(
     <Modal
+      marginLeft="0"
       type="info"
-      width="594px"
+      width="37.125rem"
       closeOnOutsideClick
       title={t(`shared:tip_position_${name}`)}
       onClose={handleCancel}

diff --git a/protocol-designer/src/organisms/TipPositionModal/index.tsx b/protocol-designer/src/organisms/TipPositionModal/index.tsx
@@ -239,8 +239,9 @@ export function TipPositionModal(
 
   return createPortal(
     <Modal
+      marginLeft="0"
       type="info"
-      width="594px"
+      width="37.125rem"
       closeOnOutsideClick
       title={t('shared:tip_position', { prefix })}
       onClose={handleCancel}

diff --git a/protocol-designer/src/organisms/WellOrderModal/index.tsx b/protocol-designer/src/organisms/WellOrderModal/index.tsx
@@ -146,6 +146,7 @@ export function WellOrderModal(props: WellOrderModalProps): JSX.Element | null {
 
   return createPortal(
     <Modal
+      marginLeft="0"
       width="37.125rem"
       closeOnOutsideClick
       type="info"

diff --git a/.../Designer/ProtocolSteps/StepForm/StepTools/ThermocyclerTools/ThermocyclerProfileModal.tsx b/.../Designer/ProtocolSteps/StepForm/StepTools/ThermocyclerTools/ThermocyclerProfileModal.tsx
@@ -60,6 +60,7 @@ export function ThermocyclerProfileModal(
 
   return (
     <Modal
+      marginLeft="0"
       zIndexOverlay={11} // toolbox zIndex is set to 10
       title={t('form:step_edit_form.field.thermocyclerProfile.edit')}
       width="45rem"
-Original file line number
+Diff line change
@@ Expand Up / @@ -169,6 +169,7 @@ export function DefineLiquidsModal( @@
           }}
         >
           <Modal
+            marginLeft="0"
             zIndexOverlay={15}
             width="42.0625rem"
             title={
@@ Expand Down @@