-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app, step-generation): visualize the step timeline and deck state of a protocol #15491
feat(app, step-generation): visualize the step timeline and deck state of a protocol #15491
Conversation
Add JSON protocol schema 8, which is similar in semantic concept to json protocol schema 7 but - Requires user specification of the schema for the command List This allows json protocols to switch which commands they're interning without requiring further bumps to the protocol schema - Does the same thing for command annotations, liquids, and labware For the same reasons. This should be a big step forward in flexibility for our protocol schemas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably exporting functions (PipetteMountViz etc) would make things easy. (testing and maintaining)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, i'll separate them out!
I guess the space between deck map and timeline in the screenshot is smaller than the screen captures you posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there any specific reason, using the same name for component name and .tsx file name.
@koji thanks for this! i'm gonna do a follow up pr to refine things a bit and will address this then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments.
the changes look good to me.
if you can issue tickets to follow up some tests, that will be helpful for us.
…e of a protocol (#15491) Create an experimental tool, behind a feature flag, that allows users to inspect the timeline of atomic commands and the resulting deck state of the robot at ever frame of the timeline. NOTE: This is for Flex only and also does not yet support the 96-channel Co-authored-by: Seth Foster <[email protected]> Co-authored-by: Max Marrone <[email protected]> Co-authored-by: Jethary <[email protected]>
Overview
Create an experimental tool, behind a feature flag, that allows users to inspect the timeline of
atomic commands and the resulting deck state of the robot at ever frame of the timeline.
NOTE: This is for Flex only and also does not yet support the 96-channel
Demo:
Screen.Recording.2024-06-26.at.16.13.49.mov
co-authored by @jerader
Turn on the Protocol timeline feature flag and click on the "go to timeline" button from the protocol overflow menu of a Flex protocol with no 96-channel.
Risk assessment
low, behind a feature flag