feat(api): add liquid state property #15553
Conversation
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
caila-marashaj
force-pushed
the
EXEC-543-liquid-state-property
branch
from
ee5df52 to
2adb717
Compare
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15554 |
| @@ -1642,6 +1643,16 @@ def flow_rate(self) -> "FlowRates": | |||
| """ | |||
| return self._core.get_flow_rate() | |||
|
|
|||
| @property | |||
| @requires_version(2, 0) | |||
| def liquid_presence_state(self) -> Optional[types.LiquidPresenceState]: | ||
| return self._liquid_presence_state | ||
|
|
||
| @liquid_presence_state.setter |
There was a problem hiding this comment.
Would we want a public setter, or should this always be driven by sensor measurements?
But you raise a good point in that now that we're adding to this it would be good to update that name to |
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15554 |
|
whoopsie duplicate ticket |
Overview
This adds a
liquid_presence_stateproperty to the protocol api's instrument context, along with an enum for the possible states.The value here is
Optionaland defaulted toNone, which I think makes sense for the ot2 case.Changelog
liquid_presence_stateLiquidPresenceStateenum inopentrons.typesReview Requests
Is there any further error handling/prevention I should do for ot2 instruments?