Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vite version to 5.4.11 #17075

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 10, 2024

Overview

update vite version to 5.4.11 and remove vite from package.json in protocol-designer
I removed vite from PD's package.json already.

close AUTH-1128

dev server

  • make -C app dev
  • make -C app dev-odd
  • make -C protocol-designer dev
  • make -C labware-library dev
  • make -C components dev
  • make -C labware-designer dev

build

  • app
  • odd
  • protocol-designer
  • labware-library

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

koji added 3 commits December 10, 2024 12:52
update vite version to 5.4.11 and remove vite from package.json in protocol-designer

close AUTH-
@koji koji marked this pull request as ready for review December 11, 2024 23:23
@koji koji requested a review from a team as a code owner December 11, 2024 23:23
@koji koji removed the request for review from a team January 8, 2025 16:35
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

update vite version to 5.4.11 and remove vite from package.json in protocol-designer

I don't see the removal from PD in the diff?

@koji
Copy link
Contributor Author

koji commented Jan 8, 2025

Thanks!

update vite version to 5.4.11 and remove vite from package.json in protocol-designer

I don't see the removal from PD in the diff?

because i removed already vite from PD's package.json last year.

@koji koji merged commit dc624b8 into edge Jan 8, 2025
46 checks passed
@koji koji deleted the chore_update-vite-to-v5-4-11 branch January 8, 2025 17:40
Laura-Danielle pushed a commit that referenced this pull request Jan 9, 2025
* chore: update vite version to 5.4.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants