feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222

jerader · 2025-01-08T20:22:32Z

closes AUTH-594 AUTH-596 AUTH-597 AUTH-598 AUTH-599

Overview

This is behind a ff so shouldn't affect anything in 8.3.0, 8.4.0, etc until we want to finish & release this feature

This PR adds single tip partial tip support for 96-channel and 8-channel, only starting at the 'default' primary nozzles which are H1 for 8-channel and H12 for 96-channel.

Note that collision warnings for deck extents, ot-2 and 8-channel are not fully supported yet.

Test Plan and Hands on Testing

Turn on the partial tip FF

create an 8-channel protocol for the Flex or OT-2, add 2 transfer steps, one with all nozzles and one with 1 nozzle. see that it looks correct and it passes analysis on the app
create a 96-channel protocol for the Flex, add 3 transfer steps, one with all nozzles, one with 1 nozzle, and one with 1 column. see that it looks correct and passes analysis on the app
turn off the FF, see that the single option is not found

Changelog

add support for single nozzle pick up for the default primary nozzle
extend support to the partial tip field, utils, and step-generation
create ff for partial tip work

Risk assessment

low, behind ff

… the default

…ult' primaryNozzle only closes AUTH-594 AUTH-596 AUTH-597 AUTH-598 AUTH-599

koji · 2025-01-09T20:34:09Z

protocol-designer/src/feature-flags/reducers.ts

@@ -31,7 +31,9 @@ const initialFlags: Flags = {
    process.env.OT_PD_ENABLE_HOT_KEYS_DISPLAY === '1' || true,
  OT_PD_ENABLE_REACT_SCAN: process.env.OT_PD_ENABLE_REACT_SCAN === '1' || false,
  OT_PD_ENABLE_LIQUID_CLASSES:
-    process.env.OT_PD_ENABLE_LIQUID_CLASSES === '1' || false,
+    process.env.OT_PD_ENABLE_REACT_SCAN === '1' || false,


i guess needs to merge edge into this branch since you fixed this already, don't you?

Suggested change

process.env.OT_PD_ENABLE_REACT_SCAN === '1' || false,

process.env.OT_PD_ENABLE_LIQUID_CLASSES === '1' || false,

koji · 2025-01-09T20:39:35Z

protocol-designer/src/organisms/Labware/SelectableLabware.tsx

@@ -101,8 +101,8 @@ export const SelectableLabware = (
    rect
  ) => {
    if (!e.shiftKey) {
-      if (nozzleType != null) {
-        const channels = getChannelsFromNozleType(nozzleType)
+      if (nozzleType != null && nozzleType !== SINGLE) {


Suggested change

if (nozzleType != null && nozzleType !== SINGLE) {

if (nozzleType !== null && nozzleType !== SINGLE) {

koji · 2025-01-09T20:39:54Z

protocol-designer/src/organisms/Labware/SelectableLabware.tsx

@@ -142,8 +142,8 @@ export const SelectableLabware = (
  }

  const handleMouseEnterWell: (args: WellMouseEvent) => void = args => {
-    if (nozzleType != null) {
-      const channels = getChannelsFromNozleType(nozzleType)
+    if (nozzleType != null && nozzleType !== SINGLE) {


same as the above

koji · 2025-01-09T20:40:58Z

protocol-designer/src/organisms/Labware/SelectableLabware.tsx

@@ -158,11 +158,11 @@ export const SelectableLabware = (

  // For rendering, show all wells not just primary wells
  const allSelectedWells =
-    nozzleType != null
+    nozzleType != null && nozzleType !== SINGLE


same as the above

koji · 2025-01-09T20:51:18Z

protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PartialTipField.tsx

+      disabled: noTipracksOnAdapter,
+      tooltipText: noTipracksOnAdapter
+        ? t('form:step_edit_form.field.nozzles.option_tooltip.partial')
+        : undefined,


can we use '' or null?

koji · 2025-01-09T20:55:28Z

protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MixTools/index.tsx

@@ -74,6 +78,9 @@ export function MixTools(props: StepFormProps): JSX.Element {
  const is96Channel =
    propsForFields.pipette.value != null &&
    pipettes[String(propsForFields.pipette.value)].name === 'p1000_96'


can we use .spec.channels since is8Channel uses that.

Suggested change

pipettes[String(propsForFields.pipette.value)].name === 'p1000_96'

pipettes[String(propsForFields.pipette.value)].spec.channels === 96

koji · 2025-01-09T20:59:35Z

protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/index.tsx

@@ -91,6 +94,9 @@ export function MoveLiquidTools(props: StepFormProps): JSX.Element {
  const is96Channel =
    propsForFields.pipette.value != null &&
    pipettes[String(propsForFields.pipette.value)].name === 'p1000_96'


same as the above

koji · 2025-01-09T21:04:25Z

protocol-designer/src/top-selectors/substep-highlight.ts

@@ -28,14 +33,17 @@ function _wellsForPipette(
  const pipChannels = pipetteEntity.spec.channels

  // `wells` is all the wells that pipette's channel 1 interacts with.
-  if (pipChannels === 8 || pipChannels === 96) {
+  if ((pipChannels === 8 || pipChannels === 96) && nozzles !== SINGLE) {
    let channels: 8 | 96 = pipChannels


Suggested change

let channels: 8 | 96 = pipChannels

let channels = pipChannels

jerader added 5 commits January 8, 2025 16:19

make feature flag

4edea49

start to add single tip support

7181278

add full support for single partial tip with the primary nozzle being…

10d626e

… the default

feat(protocol-designer): single channel partial tip support for 'defa…

418edc3

…ult' primaryNozzle only closes AUTH-594 AUTH-596 AUTH-597 AUTH-598 AUTH-599

fix failed test

422a6bc

jerader force-pushed the pd_partial-tip-single-tip-support branch from 324471b to 422a6bc Compare January 8, 2025 21:22

jerader marked this pull request as ready for review January 8, 2025 21:39

jerader requested a review from a team as a code owner January 8, 2025 21:39

jerader requested review from koji and ncdiehl11 January 8, 2025 21:39

jerader added the authorship label Jan 8, 2025

koji reviewed Jan 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222

feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222

jerader commented Jan 8, 2025 •

edited

Loading

koji Jan 9, 2025

koji Jan 9, 2025

koji Jan 9, 2025

koji Jan 9, 2025

koji Jan 9, 2025

koji Jan 9, 2025

koji Jan 9, 2025

koji Jan 9, 2025

	process.env.OT_PD_ENABLE_REACT_SCAN === '1' \|\| false,
	process.env.OT_PD_ENABLE_LIQUID_CLASSES === '1' \|\| false,

	if (nozzleType != null && nozzleType !== SINGLE) {
	if (nozzleType !== null && nozzleType !== SINGLE) {

	pipettes[String(propsForFields.pipette.value)].name === 'p1000_96'
	pipettes[String(propsForFields.pipette.value)].spec.channels === 96

	let channels: 8 \| 96 = pipChannels
	let channels = pipChannels

feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222

Are you sure you want to change the base?

feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222

Conversation

jerader commented Jan 8, 2025 • edited Loading

Overview

Test Plan and Hands on Testing

Changelog

Risk assessment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jerader commented Jan 8, 2025 •

edited

Loading