Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): check gripper use with absorbance reader #17334

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jan 23, 2025

Overview

In addition to checking move command with gripper, we need to check absorbance reader lid commands which implicitly require use of the gripper. I add this logic to both our LOAD_FILE reducer and our unused equipment warning modal.

Closes AUTH-1344

Test Plan and Hands on Testing

Changelog

  • add absorbance reader lid command checks to logic for determining whether gripper is in use

Review requests

see test plan

Risk assessment

low

In addition to checking move command with gripper, we need to check absorbance reader lid commands which implicitly require use of the gripper. I add this logic to both our LOAD_FILE reducer and our unused equipment warning modal.

Closes AUTH-1344
@ncdiehl11 ncdiehl11 self-assigned this Jan 23, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader January 23, 2025 15:35
@ncdiehl11 ncdiehl11 marked this pull request as ready for review January 23, 2025 15:35
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner January 23, 2025 15:35
@ncdiehl11 ncdiehl11 removed the request for review from a team January 23, 2025 15:35
@ncdiehl11 ncdiehl11 merged commit 7710341 into edge Jan 23, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants