Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components, protocol-designer): implement ListButton in step forms #17340

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jan 23, 2025

Overview

ListItems used for toggle/toggleExpand form fields in PD went unnoticed-- according to designs, these fields should actually return ListButtons. This PR swaps those components out where necessary and adds event stopPropogation functions to children input fields and dropdown menus click handlers.

Test Plan and Hands on Testing

  • create or import a protocol with thermocycler, heater shaker, and absorbance reader forms (only forms that include components touched here) (example)
  • verify that toggle/toggleExpand fields are now radio buttons. clicking anywhere on the container should toggle the value/expanded state
  • for expanded toggle fields, verify that interacting with children (input field, dropdown menu, menu item) does not toggle the expanded state

Changelog

  • replace ListItem with ListButton in toggle/toggleExpand form fields
  • add MouseEvent.stopPropagation protections

Review requests

see test plan

Risk assessment

medium

ListItems used for toggle/toggleExpand form fields in PD went unnoticed-- according to designs, these fields should actually return ListButtons. This PR swaps those components out where necessary and adds event stopPropogation functions to children input fields and dropdown menus click handlers.
@ncdiehl11 ncdiehl11 changed the title fix(components,-protocol-designer): implement ListButton in step forms fix(components, protocol-designer): implement ListButton in step forms Jan 23, 2025
@ncdiehl11 ncdiehl11 self-assigned this Jan 23, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader January 23, 2025 21:44
@ncdiehl11 ncdiehl11 marked this pull request as ready for review January 23, 2025 21:44
@ncdiehl11 ncdiehl11 requested review from a team as code owners January 23, 2025 21:44
@ncdiehl11 ncdiehl11 removed request for a team January 23, 2025 21:44
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nice catch to fix these!

@ncdiehl11 ncdiehl11 merged commit 78b89ed into edge Jan 24, 2025
68 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-listbutton branch January 24, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants