Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): update logic to add modules and fixtures with plate reader #17344

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Jan 24, 2025

Overview

update logic to add modules and fixtures with plate reader and align ui with the latest design

  • for onboarding flow, pd allows users to set only 1 plate reader and plate reader will be placed on B3
  • for staging area, when a user sets a plate reader, available slots of staging area in select fixtures screen is 3 because of the above requirements. available slots are A3 (because trash bin can be placed column 1 slots), C3, D3
  • remove dropdown from plate reader

design

the related thread
https://opentrons.slack.com/archives/C0866FUHXGQ/p1737665141057879

close AUTH-1287

Test Plan and Hands on Testing

  • create a new protocol and set plate reader -> plate reader on B3
  • create a new protocol and set plate reader -> available slots for staging area are 3 deck view displays plate reader on B3, 3 staging areas and trash bin is on A1
    if staging area's quantity is 1 or 2, plate reader on B3, trash bin on A3, and staging areas on C3 and D3
  • create a new protocol and do not add plate reader -> available slots for staging area are 4 and deck view displays 4 staging areas and trash bin is on A1

Changelog

  • update utils and its test
  • remove dropdown menu from plate reader's list item

Review requests

Risk assessment

mid since this PR modify the logic for module selection and fixture selection

… plate reader

update logic to add modules and fixtures with plate reader and align ui with the latest design

close AUTH-1287
@koji koji requested review from ncdiehl11 and jerader January 24, 2025 20:57
@koji koji marked this pull request as ready for review January 24, 2025 21:17
@koji koji requested a review from a team as a code owner January 24, 2025 21:17
@koji koji removed the request for review from a team January 24, 2025 21:17
@koji koji marked this pull request as draft January 24, 2025 21:24
@koji koji marked this pull request as ready for review January 24, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant