OP-22198 : Fixed KubernetesCredentialsTest UTs #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @kirangodishala and @yugaa22 because they authored those changes |
There was a problem hiding this comment.
Here is the context. For one of our clients, while debugging an issue we found the overwhelming kubernetes metrics(for every trivial operation) taking up cluster space and shadowing useful metrics. So we decided to comment the code that produce these not-so-useful metrics.
|
Closing the PR as change is for some purpose & we are not reverting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary :
Before this change : clouddriver-kubernetes 724/732 TC passed
After this change : clouddriver-kubernetes 733/733 TC passed
Testing : Compile successful, KubernetesCredentialsTest 14/14 UTs passed
Note : @nemesisOsorio need to confirm whether we need to keep this change or not.