Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single client disconnection #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Tyris0001
Copy link

I do have reason to believe that this works.

@Pithikos
Copy link
Owner

Thanks for this. However some refactoring will be required before I'll be able to merge this.

Namely there's two main issues:

  1. There's some discussion of having a dictionary of clients (Sending to a specific client #66). That will avoid unnecessary loops.
  2. I try to avoid introducing new functions if it can be done with existing ones. I think a better implementation would be to change the existing methods to simply take clients as either a list of client_id or client. That will cover more arbitrary cases (e.g. closing 2 or 3 clients) without changing the API that much. So by default all clients are disconnected unless user specifies specific clients.

@jason-c-child
Copy link

Thanks for this. However some refactoring will be required before I'll be able to merge this.

The inability to disconnect a specific client by id is a massive miss here and seriously hobbles the utility of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants