Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Authentication #21

wants to merge 3 commits into from

Conversation

shenek
Copy link

@shenek shenek commented Mar 21, 2017

This MR is designed to:

  • fix some python2/python3 inconsistencies
  • allow users to define an authentication procedure during the handshake

shenek added 3 commits March 21, 2017 10:53
* this will aviod the python2/python3 incosistency (using "new" class style for all implementations)
* fixes super() fails with error: TypeError “argument 1 must be type, not classobj” exception when overriding class methods
  see http://stackoverflow.com/questions/1713038/super-fails-with-error-typeerror-argument-1-must-be-type-not-classobj
@shenek
Copy link
Author

shenek commented Sep 8, 2017

Ping?

@Pithikos
Copy link
Owner

Pithikos commented Sep 8, 2017

@shenek sorry for the delay, I had some personal issues so did not have time to look into this. Will have a look once I find some time. Cheers

@Pithikos Pithikos force-pushed the master branch 2 times, most recently from 96ec5df to 433a826 Compare March 7, 2018 11:10
@Pithikos Pithikos force-pushed the master branch 4 times, most recently from 567a61f to 29b8706 Compare October 3, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants