chore(flags): clarify return values for boolean flags when no release condition matches #10477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… condition matches
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
havenbarnes
commented
Jan 24, 2025
| @@ -84,8 +84,6 @@ A payload is an additional piece of information sent to your app when a flag is | |||
|
|
|||
| They enable you to configure functionality related to your flag inside PostHog, instead of having to make code changes or redeploy your app. | |||
|
|
|||
| > **Note**: Payloads are only available in our JavaScript web, Node, Python, Ruby, and React libraries. | |||
There was a problem hiding this comment.
Drive-by fact check. This is false, any SDK that supports flags supports payloads
dmarticus
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context: posthog.slack.com/archives/C07Q2U4BH4L/p1737751112214639
Tweaking description of boolean flags to match actual API/SDK behavior
Related change to feature flag usage tab: PostHog/posthog#27888