Do not consider issue text in __eq__ method
#571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue text is not supposed to be consistent between banndit versions. It was changed few times in the past. That's why we don't need to match text too between issues. This issue is only valid if we compare old bandit baseline generated with the old version with a new one generated using the last bandit.
|
@e0ne Can you please open a bug on this issue and include how to recreate? Thanks |
ericwb
requested changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue text is not supposed to be consistent between banndit versions. It
was changed few times in the past. That's why we don't need to match text too
between issues.
This issue is only valid if we compare old bandit baseline generated
with the old version with a new one generated using the last bandit.