Make Auto-Evo able to evolve slime jets #5777
Conversation
|
The lead programmer for Thrive is currently on vacation until 2025-01-07. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed. PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged. |
|
I haven't tested yet, but I can verify that this is using auto-evo correctly. |
| var slimeJetsCount = 0; | ||
| var topPosition = 0; | ||
| var bottomPosition = 0; | ||
| List<int> slimeJetsVerticalPositions = new List<int>(); |
There was a problem hiding this comment.
Using temporary lists should be avoided for memory allocation efficiency.
| if (bottomPosition != topPosition) | ||
| { | ||
| // Range of [0,1] (front to back) | ||
| mucilageMultiplier = (float)(slimeJetPosition - topPosition) / (bottomPosition - topPosition); |
There was a problem hiding this comment.
Isn't this slightly wrong? Like any external organelles the slime jets jump to the closest membrane edge. So the efficiency here should just be calculated as the angle between the Y-axis and a line from the slime jet hex position to the middle hex (which is always 0,0). For examples you can take a look at the movement component movement force calculation.
Brief Description of What This PR Does
Makes it so that slime jets are taken into account in auto-evo
Related Issues
Closes #4128
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.