Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Banana Biome #5794

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Banana Biome #5794

wants to merge 1 commit into from

Conversation

HexapodPhilosopher
Copy link
Contributor

Brief Description of What This PR Does

Adds the banana biome as a rare replacement for coastal patches.

Adds a new profile in biomes.json
Alters existing banana rock model, and adds 2 smaller models.

  • Currently broken - programming help needed! There are at least 2 issues in PatchMapGenerator.cs .

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen marked this pull request as draft January 8, 2025 12:50
private static void AddBananaBiome(PatchMap map, Random random)
{
// Check Easter eggs
if (!ICurrentGameInfo.CurrentGame.GameWorld.WorldSettings.EasterEggs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line that causes this PR to not compile. The problem is that you are trying to access CurrentGame but you specified the interface name ICurrentGameInfo instead of a variable holding an instance of an object. This doesn't work as to access a property you need an instance of an object type not the type itself that defines how that object looks like. So here you would need to get the current game properties to access this data.

Though in the map generator the current game has not been created yet. Instead the Generate method receives WorldGenerationSettings settings as a parameter, which will have this info. So that needs to be used to check the easter egg status either in this method or maybe this method could be not called in the first place if easter eggs are not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: started but stuck (help wanted)
Development

Successfully merging this pull request may close these issues.

2 participants